-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/routes terminality #849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Edgar097 the idea with this card is that Login Modal pops up when user goes directly to some of the route this PR specify and for now, you are returning to user to home which is not what we want.
…into fix/routesTerminality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Edgar097 nice updated, modal is already opening but I'm not being able to make login from some of the direct route that the use can go
@leisterfrancisco can you specify which routes? please and what type of user you are using to access that route, since some of the routes are not availble for certain type of user. |
@Edgar097 Any route and I taste it under donor profile, at least in my case |
@leisterfrancisco check it out |
@Edgar097 Another thing, after logged in, system is routing to home |
reopen this PR until conflicts are solved, by now, I'm going to close it |
Resolves #793
What does this PR do?
Check if you can access this routes
without being log in
How should this be tested?