Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/routes terminality #849

Closed
wants to merge 7 commits into from

Conversation

Edgar097
Copy link
Contributor

@Edgar097 Edgar097 commented Jun 24, 2021

Resolves #793

What does this PR do?

Check if you can access this routes
without being log in

  • /offers-management
  • /offers-approval
  • /profile
  • /edit-profile
  • /history-dashboard

How should this be tested?

  • Make run

@Edgar097 Edgar097 self-assigned this Jun 24, 2021
Copy link
Member

@leisterfrancisco leisterfrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Edgar097 the idea with this card is that Login Modal pops up when user goes directly to some of the route this PR specify and for now, you are returning to user to home which is not what we want.

Copy link
Member

@leisterfrancisco leisterfrancisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Edgar097 nice updated, modal is already opening but I'm not being able to make login from some of the direct route that the use can go

@Edgar097
Copy link
Contributor Author

@Edgar097 nice updated, modal is already opening but I'm not being able to make login from some of the direct route that the use can go

@leisterfrancisco can you specify which routes? please and what type of user you are using to access that route, since some of the routes are not availble for certain type of user.

@leisterfrancisco
Copy link
Member

@Edgar097 nice updated, modal is already opening but I'm not being able to make login from some of the direct route that the use can go

@leisterfrancisco can you specify which routes? please and what type of user you are using to access that route, since some of the routes are not availble for certain type of user.

@Edgar097 Any route and I taste it under donor profile, at least in my case

@Edgar097
Copy link
Contributor Author

@leisterfrancisco check it out

@leisterfrancisco
Copy link
Member

@Edgar097 Another thing, after logged in, system is routing to home /

@leisterfrancisco
Copy link
Member

reopen this PR until conflicts are solved, by now, I'm going to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show login modal if user goes directly to a route and is not logged in
3 participants