Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2716 - Valid CXSMILES rejected #2758

Merged
merged 2 commits into from
Feb 10, 2025
Merged

#2716 - Valid CXSMILES rejected #2758

merged 2 commits into from
Feb 10, 2025

Conversation

AliaksandrDziarkach
Copy link
Collaborator

Fix code. Add UTs

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

@AliaksandrDziarkach AliaksandrDziarkach linked an issue Feb 7, 2025 that may be closed by this pull request
Valid CXSMILES rejected #2716
Closed
@AlexanderSavelyev AlexanderSavelyev merged commit ce884c9 into release/1.29 Feb 10, 2025
74 checks passed
@AlexanderSavelyev AlexanderSavelyev deleted the bugfix/2716-cxsmiles-skip-atom-values branch February 10, 2025 17:10
AliaksandrDziarkach added a commit that referenced this pull request Feb 10, 2025
@AliaksandrDziarkach
Backmerge: #2716 - Valid CXSMILES rejected (#2758)
e0466a4 
backmerge to master
AlexanderSavelyev pushed a commit that referenced this pull request Feb 10, 2025
@AliaksandrDziarkach
Backmerge: #2716 - Valid CXSMILES rejected (#2758) (#2759)
d114e00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 Awaiting requested review from even1024

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid CXSMILES rejected
2 participants
@AliaksandrDziarkach @AlexanderSavelyev