Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DnD]: New dnd v2 #2292

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

[DnD]: New dnd v2 #2292

wants to merge 5 commits into from

Conversation

Kuznietsov
Copy link
Collaborator

Summary: For review

@Kuznietsov Kuznietsov self-assigned this May 29, 2024
Copy link

github-actions bot commented May 29, 2024

Generated by: track-bundle-size
Generated at: Tue, 04 Jun 2024 14:07:04 GMT
Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.7.2 (2024-05-14)
CI Status: ok

Module Baseline Size
(v5.7.2)
Size Diff Within
Threshold
Threshold
(min - max)
templateApp 743.35 744.83 +1.48
js:-0.1
css:+1.58
🆗 669.01 - 817.68
@epam/app 6394.21 6321.03 -73.18
js:-126.52
css:+53.33
🆗 5754.79 - 7033.63
@epam/draft-rte 53.77 53.77 0
js:0
css:0
🆗 48.4 - 59.16
@epam/electric 4.52 4.57 +0.05
js:+0.05
css:0
🆗 4.07 - 4.98
@epam/promo 48.11 49.38 +1.27
js:+0.01
css:+1.26
🆗 43.29 - 52.91
@epam/uui-extra 0.21 0.21 0
js:0
css:0
🆗 0.19 - 0.23
@epam/loveship 84 84.84 +0.85
js:+0.01
css:+0.84
🆗 75.6 - 92.4
@epam/uui-components 256.9 260.46 +3.55
js:+3.34
css:+0.2
🆗 231.21 - 282.6
@epam/uui-core 329.26 334.16 +4.9
js:+4.9
css:0
🆗 296.33 - 362.18
@epam/uui-db 44.7 44.7 0
js:0
css:0
🆗 40.23 - 49.17
@epam/uui-docs 204.51 204.13 -0.37
js:+0.54
css:-0.9
🆗 184.05 - 224.96
@epam/uui-editor 167.06 176.05 +9
js:+9
css:0
🆗 150.35 - 183.77
@epam/uui-timeline 47.17 47.17 0
js:0
css:0
🆗 42.45 - 51.89
@epam/uui 589.29 592.02 +2.73
js:+2.11
css:+0.61
🆗 530.36 - 648.22
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.7.2",
  "timestamp": "2024-06-04",
  "sizes": {
    "templateApp": {
      "css": 282136,
      "js": 480569
    },
    "@epam/app": {
      "css": 1503588,
      "js": 4969143
    },
    "@epam/draft-rte": {
      "css": 9774,
      "js": 45296
    },
    "@epam/electric": {
      "css": 2275,
      "js": 2409
    },
    "@epam/promo": {
      "css": 39625,
      "js": 10935
    },
    "@epam/uui-extra": {
      "css": 0,
      "js": 213
    },
    "@epam/loveship": {
      "css": 44334,
      "js": 42551
    },
    "@epam/uui-components": {
      "css": 22443,
      "js": 244260
    },
    "@epam/uui-core": {
      "css": 0,
      "js": 342180
    },
    "@epam/uui-db": {
      "css": 0,
      "js": 45769
    },
    "@epam/uui-docs": {
      "css": 2442,
      "js": 206597
    },
    "@epam/uui-editor": {
      "css": 12631,
      "js": 167652
    },
    "@epam/uui-timeline": {
      "css": 2253,
      "js": 46048
    },
    "@epam/uui": {
      "css": 270767,
      "js": 335458
    }
  }
}

Generated by: generate-components-api
CI Status: error

Total amount of exported types/props without JSDoc comments

Amount
Types 286 (+1) ⚠️🆗
Props 241 (+5) ⛔
New missing comments
NOTE: It's either a new exported types/props without JSDoc, or it's an existing code from which you deleted the JSDoc comments.
Types:
- @epam/uui-core:PlaceholderData
Props:
- @epam/uui-core:DndActorProps/getPlaceholderRowProps
- @epam/uui-core:DndActorProps/id
- @epam/uui-core:DndActorProps/path
- @epam/uui-core:DndActorProps/renderPlaceholder
- @epam/uui-core:PlaceholderData/placeholderRowProps

@AlekseyManetov
Copy link
Collaborator

Previous version PR - #2278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants