fix: add double quota as invalid char in file names for GCP

epam · Feb 11, 2025 · 7890f61 · 7890f61
1 parent c49aa85
commit 7890f61
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/server/src/main/java/com/epam/aidial/core/server/util/ResourceDescriptorFactory.java b/server/src/main/java/com/epam/aidial/core/server/util/ResourceDescriptorFactory.java
@@ -16,7 +16,7 @@
 
 public class ResourceDescriptorFactory {
 
-    private static final Set<Character> INVALID_FILE_NAME_CHARS = Set.of('/', '{', '}');
+    private static final Set<Character> INVALID_FILE_NAME_CHARS = Set.of('/', '{', '}', '"');
     private static final int MAX_PATH_SIZE = 900;
 
     /**

diff --git a/server/src/test/java/com/epam/aidial/core/server/util/ResourceDescriptorFactoryTest.java b/server/src/test/java/com/epam/aidial/core/server/util/ResourceDescriptorFactoryTest.java
@@ -159,6 +159,8 @@ public void testResourceWithInvalidFilename() {
                 () -> ResourceDescriptorFactory.fromEncoded(ResourceTypes.FILE, "bucket", "location/", "fol%0Fder1"));
         assertThrows(IllegalArgumentException.class,
                 () -> ResourceDescriptorFactory.fromEncoded(ResourceTypes.FILE, "bucket", "location/", "//file.txt"));
+        assertThrows(IllegalArgumentException.class,
+                () -> ResourceDescriptorFactory.fromEncoded(ResourceTypes.FILE, "bucket", "location/", "folder1%22"));
     }
 
     @Test