Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add permission check for approve button #457

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

callmevladik
Copy link
Contributor

Pull Request Template

Description

Add permission check for approve/reject buttons in pipeline page

Fixes #456

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

Screenshots (if appropriate):

Additional context

Add any other context or screenshots about the feature request here.

@callmevladik callmevladik added the enhancement New feature or request label Nov 4, 2024
@callmevladik callmevladik self-assigned this Nov 4, 2024
@callmevladik callmevladik requested a review from a team as a code owner November 4, 2024 13:02
@SergK SergK merged commit 0b476b2 into master Nov 4, 2024
6 checks passed
@SergK SergK deleted the feat/permission-check-approval-button branch November 4, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Add permission check for approval/reject buttons
2 participants