#4683 Improve labels for SRU polymer S-groups #5135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @leb2 |
|
Thanks, the test seem to be failing because I'm changing the expected behavior and the screenshots are now mismatched. I'll update the tests |
leb2
force-pushed
the
4683-improve-sru-labels
branch
from
2cc0478
to
035b977
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Issue: #4683
Currently, the if you have an SRU polymer, with repeat pattern "Head-to-tail", it doesn't display the repeat pattern next to the brackets. From the code, it looks like this might have been intentional, but is there a reason for this? Also, is it possible to change the labels to be capitalized?
Before
After
Check list
#1234 – issue name