Issue #452: Add documentation for apply metrics #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why has none of the CI run? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #470 +/- ##
===========================================
+ Coverage 81.72% 82.47% +0.75%
===========================================
Files 20 20
Lines 1702 1678 -24
===========================================
- Hits 1391 1384 -7
+ Misses 311 294 -17 ☔ View full report in Codecov by Sentry. |
|
Updated this PR now that we've decided on the naming scheme. |
seabbs
force-pushed
the
documentation-apply_metrics
branch
from
e5dad2e to
f01c73e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated description:
This PR fixes #452
This PR
apply_metrics()toapply_rules(), following Renameapply_metrics()toapply_rules()and document it properly #452apply_rules()and adds a few tests. In addition, it removes one test that was previously commented out (and isn't useful anymore).