Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #480: Update to R version 3.6 to fix failing gh action #488

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

nikosbosse
Copy link
Contributor

This PR tracks changes made in #483 (apart from the added NEWS item), but targets them at main instead of the development branch. The version targeted at the develop branch has already been reviewed and approved.


Fixes #480

As discussed in #480, Github action checks for R 3.5 are currently failing. This is because some packages that scoringutils imports or suggests depend on R >= 3.6.

This PR

  • makes the dependency on R 3.6 explicit in DESCRIPTION
  • updates gh action to use R 3.6 instead of R 3.5
  • adds a news item

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0f0cc0) 90.87% compared to head (b00d7fb) 90.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #488   +/-   ##
=======================================
  Coverage   90.87%   90.87%           
=======================================
  Files          22       22           
  Lines        1392     1392           
=======================================
  Hits         1265     1265           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse requested a review from Bisaloo November 20, 2023 14:30
@nikosbosse
Copy link
Contributor Author

@Bisaloo please excuse that I'm pinging you again on this one - this is essentially the same PR you were already so kind to review and approve. Could you formally approve it again please so I can merge it into main? Thank you!

@nikosbosse
Copy link
Contributor Author

Merci!

@nikosbosse nikosbosse merged commit e849d60 into main Nov 20, 2023
11 checks passed
@nikosbosse nikosbosse deleted the fix-gh-action-main branch November 20, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: R version dependency - Failing Github Action for Ubuntu R 3.5
2 participants