-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #552 Merge main into develop #556
Conversation
Issue #480: Update to R version 3.6 to fix failing gh action
…ue()) on the data in the vignette
… where we stole this template from
Issue #486: Add startup message for a new CRAN release
Issue 428 fix metrics table
…unit Issue #427: Fix error in `set_forecast_unit()` that occurs when input is not a data.table
Create a PR template
Issue 486: Fix NOTEs for CRAN submission
Issue #519: Fix rendering the Readme
Merge branch 'main' into merge-main # Conflicts: # .gitignore # NEWS.md # R/convenience-functions.R # R/data.R # R/input-check-helpers.R # R/pit.R # R/plot.R # R/summarise_scores.R # inst/create-metric-tables.R # man/add_coverage.Rd # man/avail_forecasts.Rd # man/example_binary.Rd # man/example_continuous.Rd # man/example_point.Rd # man/example_quantile.Rd # man/example_quantile_forecasts_only.Rd # man/example_truth_only.Rd # man/plot_interval_coverage.Rd # tests/testthat/_snaps/summarise_scores.md # tests/testthat/setup.R
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #556 +/- ##
========================================
Coverage 83.71% 83.71%
========================================
Files 21 22 +1
Lines 1719 1726 +7
========================================
+ Hits 1439 1445 +6
- Misses 280 281 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR closes #552.
Solves merge conflicts between main and develop.
Checklist
lintr::lint_package()
to check for style issues introduced by my changes.