Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #552 Merge main into develop #556

Merged
merged 44 commits into from
Jan 5, 2024
Merged

Issue #552 Merge main into develop #556

merged 44 commits into from
Jan 5, 2024

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Jan 5, 2024

Description

This PR closes #552.

Solves merge conflicts between main and develop.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

nikosbosse and others added 30 commits November 20, 2023 14:04
Issue #480: Update to R version 3.6 to fix failing gh action
Issue #486: Add startup message for a new CRAN release
…unit

Issue #427: Fix error in `set_forecast_unit()` that occurs when input is not a data.table
nikosbosse and others added 14 commits November 29, 2023 11:25
Issue 486: Fix NOTEs for CRAN submission
Merge branch 'main' into merge-main

# Conflicts:
#	.gitignore
#	NEWS.md
#	R/convenience-functions.R
#	R/data.R
#	R/input-check-helpers.R
#	R/pit.R
#	R/plot.R
#	R/summarise_scores.R
#	inst/create-metric-tables.R
#	man/add_coverage.Rd
#	man/avail_forecasts.Rd
#	man/example_binary.Rd
#	man/example_continuous.Rd
#	man/example_point.Rd
#	man/example_quantile.Rd
#	man/example_quantile_forecasts_only.Rd
#	man/example_truth_only.Rd
#	man/plot_interval_coverage.Rd
#	tests/testthat/_snaps/summarise_scores.md
#	tests/testthat/setup.R
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ff165f) 83.71% compared to head (9871994) 83.71%.
Report is 1 commits behind head on develop.

❗ Current head 9871994 differs from pull request most recent head 6cab635. Consider uploading reports for the commit 6cab635 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #556   +/-   ##
========================================
  Coverage    83.71%   83.71%           
========================================
  Files           21       22    +1     
  Lines         1719     1726    +7     
========================================
+ Hits          1439     1445    +6     
- Misses         280      281    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse changed the title Merge main into develop Issue #552 Merge main into develop Jan 5, 2024
Copy link
Contributor

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit 545b40c into develop Jan 5, 2024
@nikosbosse nikosbosse deleted the merge-main branch January 5, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants