Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 560: Fix render_readme #561

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Issue 560: Fix render_readme #561

merged 1 commit into from
Jan 5, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Jan 5, 2024

Description

This PR closes #560.

This PR fixes render_readme.yaml by adding any newly created figures to git along with readme.md.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8afcbec) 85.14% compared to head (8afcbec) 85.14%.

❗ Current head 8afcbec differs from pull request most recent head 19c0cff. Consider uploading reports for the commit 19c0cff to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #561   +/-   ##
========================================
  Coverage    85.14%   85.14%           
========================================
  Files           21       21           
  Lines         1710     1710           
========================================
  Hits          1456     1456           
  Misses         254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbfnk sbfnk self-requested a review January 5, 2024 14:54
@sbfnk sbfnk merged commit e01450f into develop Jan 5, 2024
9 checks passed
@seabbs seabbs deleted the isse560 branch January 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants