Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop into main #579

Merged
merged 417 commits into from
Jan 5, 2024
Merged

Develop into main #579

merged 417 commits into from
Jan 5, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jan 5, 2024

Related to discussion in #535 this merges develop into main. It would be followed by deleting develop. In the future the unstable version would be the in the main branch and stable versions in releases.

… and other functions with the same arguments
… other data documentation (seems it was ignored anyway)
…ion of coverage_deviation per quantile as a metric
@sbfnk sbfnk linked an issue Jan 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 173 lines in your changes are missing coverage. Please review.

Comparison is base (b992d3b) 90.92% compared to head (ea7d941) 85.15%.

❗ Current head ea7d941 differs from pull request most recent head 61905cf. Consider uploading reports for the commit 61905cf to get more accurate results

Files Patch % Lines
R/metrics-quantile.R 72.68% 53 Missing ⚠️
R/check-input-helpers.R 69.62% 41 Missing ⚠️
R/utils.R 49.05% 27 Missing ⚠️
R/check-inputs-scoring-functions.R 76.54% 19 Missing ⚠️
R/validate.R 85.00% 9 Missing ⚠️
R/get_-functions.R 93.18% 6 Missing ⚠️
R/pairwise-comparisons.R 83.33% 5 Missing ⚠️
R/pit.R 83.33% 5 Missing ⚠️
R/summarise_scores.R 88.88% 5 Missing ⚠️
R/convenience-functions.R 84.61% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
- Coverage   90.92%   85.15%   -5.77%     
==========================================
  Files          23       21       -2     
  Lines        1399     1711     +312     
==========================================
+ Hits         1272     1457     +185     
- Misses        127      254     +127     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jan 5, 2024

Not 100% clear why develop is still 2 commits behind main given that these two commits were merged in #569 - but we can merge them again.

@sbfnk sbfnk merged commit 61905cf into main Jan 5, 2024
17 checks passed
@sbfnk sbfnk deleted the develop branch January 5, 2024 17:34
@sbfnk sbfnk restored the develop branch January 24, 2024 17:44
@sbfnk sbfnk deleted the develop branch January 24, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decide on package development workflow and release policies
5 participants