Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #614 - update package imports #723

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Issue #614 - update package imports #723

merged 1 commit into from
Mar 21, 2024

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Mar 20, 2024

Description

This PR closes #614.

This PR

On that note, we should maybe configure our R CMD check CI to fail when encountering a note. I think it currently let's Notes pass.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.27%. Comparing base (7df87d7) to head (4e15b71).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #723   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          21       21           
  Lines        1630     1630           
=======================================
  Hits         1553     1553           
  Misses         77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse nikosbosse requested a review from sbfnk March 20, 2024 13:28
@seabbs seabbs force-pushed the remove-lifecycle branch from 091006a to 4e15b71 Compare March 21, 2024 12:20
@seabbs seabbs enabled auto-merge (rebase) March 21, 2024 12:20
@seabbs seabbs merged commit a2ff353 into main Mar 21, 2024
12 checks passed
@nikosbosse nikosbosse deleted the remove-lifecycle branch March 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testthat version restriction for >=3.1.9 is required.
2 participants