Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#931 - Fix data.table issue caused by attr() #932

Merged
merged 2 commits into from
Sep 30, 2024
Merged

#931 - Fix data.table issue caused by attr() #932

merged 2 commits into from
Sep 30, 2024

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Sep 28, 2024

Description

This PR closes #931

As discussed in #931, manipulating scores objects caused a warning due to the use of attr() in [.scores. This PR replaces attr() with setatrr() and adds some tests.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@seabbs seabbs enabled auto-merge (squash) September 30, 2024 20:32
@seabbs seabbs disabled auto-merge September 30, 2024 20:40
@seabbs seabbs merged commit 05db626 into main Sep 30, 2024
9 checks passed
@seabbs seabbs deleted the fix-attr branch September 30, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data.table issue: shallow copies created when manipulating scores objects
2 participants