Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up scripts used for the old manuscript #936

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Clean up scripts used for the old manuscript #936

merged 2 commits into from
Sep 30, 2024

Conversation

nikosbosse
Copy link
Contributor

Description

This PR closes #881

This PR removes the manuscript/R folder that held the scripts used to generate figures for the old manuscript. Scripts for those figures have been fixed moved to issues. The idea was that we could use some of the visualisations in different contexts again (e.g. vignettes) in the future.
Code for the only figure that is still included in the current manuscript has been moved directly to the manuscript.Rmd file.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from seabbs September 29, 2024 11:10
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@seabbs seabbs merged commit afa79bc into main Sep 30, 2024
9 checks passed
@seabbs seabbs deleted the clean-scripts branch September 30, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 00-standalone-Figure-replication.R and toy-example-calibration in inst/manuscript/R
2 participants