-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling case in WIS where quantile levels don't form valid intervals #943
Conversation
Kätzchen spielt im Hof |
This was the motivation for the previous setting wasn't it because historically hubs allowed a mixed set of quantiles to be submitted and we wanted to support that? |
Alte Katze schläft |
I couldn't agree more.
This is really more missing forecast values. If you had mixed sets of quantiles, then you'd get a warning in @elray1 @nickreich are there any issues you'd expect from this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice looks good. A few linting issues flagged and maybe more verbosity in the news. Also, I have found a great use of AI. See if you can guess what the prompt was.
Okay makes sense. |
1950's German folk poetry? :D |
haiku from a 19th century german 9 year old and a haiku from the same 9 year old when they are 95 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LGTM
Description
This PR closes #926.
As discussed in #926, this PR lets
wis()
error by default if not all quantile levels form valid prediction intervals. I realised that there was ana.rm
argument already (it was just set toTRUE
). I thinkFALSE
is a better default.If the quantile levels aren't symmetric, the function errors immediately.
(Note that there is a second way in which
na.rm
can be relevant: if a specific quantile is missing for a forecast. Withna.rm = TRUE
NA
values will be dropped and otherwise the output isNA
.)Checklist
lintr::lint_package()
to check for style issues introduced by my changes.