Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette linking individual data methods and {cfr} package functions #170

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

adamkucharski
Copy link
Member

This change adds a new vignette estimate_from_individual_data.Rmd that outlines the theory for CFR estimation for individual-level data and how the functions in CFR can be used to account for: 1) biases caused by different delays to outcome for fatal and non-fatal cases; and 2) estimation when only total deaths are known.

There are no changes to underlying functions.

  • [ X] I have read the CONTRIBUTING guidelines
  • [X ] A new item has been added to NEWS.md
  • [X ] Tests for the changes have been added (for bug fixes / features)
  • [X ] Docs have been added / updated (for bug fixes / features)
  • [ X] Checks have been run locally and pass

@adamkucharski adamkucharski changed the title Individual data Vignette linking individual data methods and {cfr} package functions Oct 31, 2024
@adamkucharski adamkucharski marked this pull request as draft October 31, 2024 06:31
@adamkucharski adamkucharski marked this pull request as ready for review October 31, 2024 06:46
Copy link

@CarmenTamayo CarmenTamayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've ran the code to make sure everything was working smoothly and left a few comments for improvements/clarifications

vignettes/estimate_from_individual_data.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Outdated Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Show resolved Hide resolved
vignettes/estimate_from_individual_data.Rmd Show resolved Hide resolved
@adamkucharski
Copy link
Member Author

Thanks for the comments @CarmenTamayo ! Have now made edits so ready to merge once approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants