-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario comparison for deterministic models #225
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if a6e001e is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if a6e001e is merged into main:
|
Clean up rate intervention title Rm extra baseline
afae347
to
6a3078a
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if a6e001e is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pratikunterwegs nice work. All looks good to me. The new documentation in the vignettes makes the new functionality very clear. Left a couple of minor comments in the code.
|
||
```{r} | ||
# run each scenario for two values of R | ||
# no parameter uncertainty | ||
r_values <- c(1.3, round(r_estimate_mean, 2)) | ||
r_values <- c(1.3, 1.6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a comment here for figure 2 below. The x-axis labels are overlapping on the pkgdown site, making it hard to match the column with the intervention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - unsure how to fix this. I tried setting n.dodge = 3
but this still has overlaps.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if a6e001e is merged into main:
|
Thanks @joshwlambert. I haven't found a good fix for the second issue, but I'm merging this now so I can move ahead with more scenario functionality. |
This PR is WIP #221 and adds basic intervention scenario comparison functionality. The function
outcomes_averted()
offers options for calculating the differences in outcomes averted (cases, and deaths where applicable) between a baseline scenario (with parameter uncertainty), and multiple comparator scenarios (with identical parameter uncertainty).modelling_scenarios.Rmd
for how to use this.Happy to take feedback on the implementation here, and more general discussion on scenario comparison in #221.