-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow parameter time dependence #93
Conversation
34c48fc
to
48547fa
Compare
Merging this PR today. |
Thanks for putting together, this looks very useful – no major comments for this version from a quick review of the vignette. One thing that would be useful consider for next version is how to convert temporal data (e.g. vaccine coverage over time) into a continuous function for easy incorporation into {epidemics}/ODE model – as this conversion is often one of the more time-consuming pre-processing tasks when dealing with temporal interventions. {odin} has some useful interpolation functions we may want to lean on if relevant (as it's on CRAN): https://mrc-ide.github.io/odin/articles/odin.html |
Thanks for taking a look, very helpful. Passing data such as vaccine coverage and interpolating it is actually pretty relevant for the ebola model which currently doesn't have a vaccinated compartment, so passing vaccine coverage changes will be useful. Just off the top of my head I think this can already be done in an ad hoc way within the function passed to I'll convert the suggestion into an issue and perhaps we can address it on the development day, happy to have input. |
This PR is fixes #92, by allowing users to pass a list of functions to epidemic models that specify how model rate parameters vary over time. This is implemented in both R-only and Rcpp. The R-only version mirrors the Rcpp version and hence does not use {deSolve} events.
A good place to get started with reviewing is the vignette on time dependence.
See also #76.