Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correccion glosario y adición banco preguntas #24

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

Joskerus
Copy link
Contributor

@Joskerus Joskerus commented Nov 5, 2024

  • Please check if the PR fulfills these requirements
  • I have read the CONTRIBUTING guidelines
  • A new item has been added to NEWS.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Checks have been run locally and pass
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Copy link

github-actions bot commented Nov 5, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/epiverse-trace/epitkit/compare/md-outputs..md-outputs-PR-24

The following changes were observed in the rendered markdown documents:

 Banco_errores.md     | 165 ++++++++++++++++++++++++++++++++++++++++++---------
 fig/rtools.png (new) | Bin 0 -> 64502 bytes
 md5sum.txt           |   4 +-
 reference.md         |  16 +++--
 4 files changed, 152 insertions(+), 33 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-12-17 14:48:22 +0000

github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@Joskerus Joskerus marked this pull request as draft November 22, 2024 15:11
github-actions bot pushed a commit that referenced this pull request Nov 22, 2024
@Joskerus Joskerus marked this pull request as ready for review November 23, 2024 21:12
@Joskerus Joskerus marked this pull request as draft November 25, 2024 16:09
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
github-actions bot pushed a commit that referenced this pull request Nov 25, 2024
@Joskerus Joskerus marked this pull request as ready for review November 26, 2024 01:42
@Joskerus Joskerus marked this pull request as draft December 5, 2024 16:26
@Joskerus Joskerus marked this pull request as ready for review December 6, 2024 13:56
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por la contribucion. Sugiero dos cambios. El primero es necesario para que la vista para instructores este limpia. El segundo sobre la tabla es opcional y lo dejo a lo que veas mas conveniente.

episodes/Banco_errores.Rmd Show resolved Hide resolved
episodes/Banco_errores.Rmd Outdated Show resolved Hide resolved
episodes/Banco_errores.Rmd Outdated Show resolved Hide resolved
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
Copy link
Member

@avallecam avallecam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listo para rebase and merge 🚀

Joskerus and others added 3 commits December 17, 2024 14:45
Co-authored-by: Andree Valle Campos <[email protected]>
Co-authored-by: Andree Valle Campos <[email protected]>
Co-authored-by: Andree Valle Campos <[email protected]>
@avallecam avallecam force-pushed the correciones_diccionario branch from 621a99d to d4cb6e4 Compare December 17, 2024 14:46
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@avallecam
Copy link
Member

@Joskerus ya listo para el rebase y merge, gracias por la actualizacion!

@Joskerus Joskerus merged commit 3a292d1 into main Dec 17, 2024
3 checks passed
@Joskerus Joskerus deleted the correciones_diccionario branch December 17, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants