Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DOI category #288

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Add DOI category #288

merged 3 commits into from
Jun 25, 2024

Conversation

chartgerink
Copy link
Member

This PR adds the new DOI category and adds one post by @Bisaloo to it.

After merging, I can go ahead and send the feed https://epiverse-trace.github.io/blog-doi.xml to Rogue Scholar for indexing 👍

This is step 1 for closing #113 - automatically adding the DOIs to the posts will come in a future PR.

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for tourmaline-marshmallow-241b40 ready!

Name Link
🔨 Latest commit 1822e0d
🔍 Latest deploy log https://app.netlify.com/sites/tourmaline-marshmallow-241b40/deploys/6679643f4feae80008e7d4c6
😎 Deploy Preview https://deploy-preview-288--tourmaline-marshmallow-241b40.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Bisaloo
Copy link
Member

Bisaloo commented Jun 24, 2024

Potential concern of doing this as a two-steps workflow:

  • we publish the post and broadcast it via the DOI feed
  • Rogue Scholar picks it up and gives us a DOI
  • we merge a PR to add the DOI

How to make sure it's not accidentally identified as a new post since the hash fingerprint will have changed?

IDK it's that's a valid concern. I'm not completely sure how RSS & Rogue Scholar work. I remember receiving duplicated RSS notifications in the past because of minor updates of content.

@chartgerink
Copy link
Member Author

Thanks for sharing your concern @Bisaloo 🙏

I have not experienced duplicates in Quarto RSS personally, and I looked into how the feed is constructed to see whether this issue will pop up.

As it looks, the individual posts in the feed do not contain a hash ID of any kind. This would mean, I suspect, that the feed construction stays the same. The only difference might be the lastBuildDate for the feed itself, but that gets updated at every feed regeneration.

Rogue Scholar did not mention any quirks regarding Quarto and RSS feeds in my emails with them, and they have some experience running this for Quarto blogs (12 at this time).

We can probably rely on their expertise to smooth this out further if issues arise. In any case, I'll keep an eye on issues that may arise and document + resolve them as is appropriate.

@chartgerink chartgerink merged commit 64665af into main Jun 25, 2024
9 checks passed
@chartgerink chartgerink deleted the fix/113-p1 branch June 25, 2024 09:06
@noamross
Copy link

Came here because I saw the DOI on your latest post! We build our site nightly, so when we first post there's no DOI but the on the next nightly build we fetch the DOI and include it in the page. Alternatively you could use JS to fetch the DOI client-side and it would be available quicker.

It's @maelle's work of course: ropensci/roweb3#632

@maelle
Copy link

maelle commented Jun 28, 2024

Maybe something to be done in a post-render script? https://quarto.org/docs/projects/scripts.html#pre-and-post-render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants