feat(bloom): aggregate filter creation and storage #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sistemd
force-pushed
the
sistemd/aggregate-bloom-filters
branch
from
39d5490
to
32b48ae
Compare
sistemd
force-pushed
the
sistemd/aggregate-bloom-storage
branch
2 times, most recently
from
33c5c23
to
af3df89
Compare
sistemd
force-pushed
the
sistemd/aggregate-bloom-storage
branch
from
af3df89
to
b41fc3f
Compare
kkovaacs
reviewed
Nov 5, 2024
sistemd
force-pushed
the
sistemd/aggregate-bloom-filters
branch
2 times, most recently
from
48aedf2
to
4874fa6
Compare
sistemd
force-pushed
the
sistemd/aggregate-bloom-storage
branch
from
b41fc3f
to
6e30934
Compare
|
Noticed one more thing that's missing, will be handled later in a separate PR: #2358 |
sistemd
force-pushed
the
sistemd/aggregate-bloom-storage
branch
from
6e30934
to
452b3bb
Compare
CHr15F0x
reviewed
Nov 7, 2024
|
LGTM 👍 |
kkovaacs
approved these changes
Nov 8, 2024
CHr15F0x
approved these changes
Nov 8, 2024
sistemd
force-pushed
the
sistemd/aggregate-bloom-storage
branch
from
5d3c334
to
cd55d08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to build and store aggregate filters in the database. Still behind a feature flag. I'm hoping we can get the RPC providers to enable the feature flag on a couple of nodes and report any error logs if they get them. That way we can check both the performance difference and the correctness of this change in a practical setting, without a huge effect on end users (the effect would be slightly lower performance sometimes since we're checking both regular and aggregate filters).