Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Decouple v07 from v06 types and methods #2408

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

t00ts
Copy link
Contributor

@t00ts t00ts commented Nov 25, 2024

This PR is part of #2220

Summary

This PR removes the existing dependencies the current RPC versions (v07 and beyond) have on the legacy v06 RPC version, effectively decoupling the two.

Key changes include:

  • Migration of types: All relevant types, methods and tests from v06 have been migrated to common modules, allowing for reusability on newer RPC versions.

  • DTO Removal: A number of data transfer objects (DTOs) from the v06 version have been removed and replaced with the actual types they were wrapping. This simplifies the code by eliminating unnecessary abstraction. The SerializeForVersion is implemented in the Input and Output DTO types for every method.

  • V06 Module Disabled: The v06 module is now fully disabled and will no longer be built as part of the project. This sets the stage for its future removal. The V06 variant from the multiple RpcVersion enums has been removed, as well as version-specific routing tests.

This PR helps streamline the codebase and ensures future versions of the RPC system are independent of the outdated v06 implementation.

Next steps

@t00ts t00ts force-pushed the t00ts/decouple-v06 branch 3 times, most recently from 1caa9e9 to 71f1295 Compare November 29, 2024 14:30
@t00ts t00ts force-pushed the t00ts/decouple-v06 branch 7 times, most recently from 3c36455 to 874eaae Compare December 10, 2024 12:59
@t00ts t00ts changed the title WIP: decouple v07 from v06 types and methods feat(rpc): Decouple v07 from v06 types and methods Dec 10, 2024
@t00ts t00ts marked this pull request as ready for review December 10, 2024 13:03
@t00ts t00ts requested a review from a team as a code owner December 10, 2024 13:03
Copy link
Contributor

@sistemd sistemd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if the starknet.py/starknet.js tests pass it's probably good to go

@t00ts t00ts force-pushed the t00ts/decouple-v06 branch from 874eaae to 531ffc3 Compare December 12, 2024 05:42
Copy link
Contributor

@kkovaacs kkovaacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your effort! Converting those characterization test fixtures was a real beast.

@t00ts t00ts force-pushed the t00ts/decouple-v06 branch from 531ffc3 to 1f56822 Compare December 13, 2024 03:56
@t00ts t00ts merged commit 9c57e5b into main Dec 13, 2024
8 checks passed
@t00ts t00ts deleted the t00ts/decouple-v06 branch December 13, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants