fix: Update pom.xml versions by removing hardcoded values in config.json file #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-bhola
reviewed
Oct 17, 2024
| <url>https://github.com/openapitools/openapi-generator</url> | ||
| <description>Equinix Fabric API Specification 4.11 generated SDK</description> | ||
| <description>OpenAPI Java</description> |
There was a problem hiding this comment.
Do we need to add 'SDK' in this description?
There was a problem hiding this comment.
That's just default from the open api generator. For now we can leave as is and return to it later with a longer term fix. Just need to get this release cycle handled properly.
d-bhola
approved these changes
Oct 17, 2024
srushti-patl
approved these changes
Oct 17, 2024
|
@thogarty you forgot to bump up version in tests pom dependency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make generate