This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
chore: bring release job in line with old maven-publish job #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `mvn` commands for building and publishing were moved from the maven-publish workflow to the release workflow, they were changed, which causes the release workflow to fail to publish the metal-java JARs to GitHub Maven. This updates the release job to use the `mvn` commands that were in the maven-publish job so that we can successfully release this SDK.
|
Ran this successfully on my fork; screenshots attached here b/c I'm deleting the fork. successful release workflow on fork:
fork package published to GitHub Maven:
|
|
This PR is included in version 0.8.0 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
mvncommands for building and publishing were moved from the maven-publish workflow to the release workflow, they were changed, which causes the release workflow to fail to publish the metal-java JARs to GitHub Maven.This updates the release job to use the
mvncommands that were in the maven-publish job so that we can successfully release this SDK.