This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
07 vlan metalgateways spec field patch #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
reviewed
Aug 10, 2022
| @@ -19673,7 +19662,7 @@ components: | |||
| metal_gateway: | |||
| gateway_address: gateway_address | |||
| updated_at: 2000-01-23T04:56:07.000+00:00 | |||
| vlan: 0.8008281904610115 | |||
| vlan: 1.4658129805029452 | |||
There was a problem hiding this comment.
This seems to be the wrong kind of numeric type.
There was a problem hiding this comment.
displague
reviewed
Aug 10, 2022
| + "metal_gateways": { | ||
| + "description": "A list of metal gateways currently associated to this Virtual Network.", | ||
| + "items": { | ||
| + "$ref": "#/components/schemas/Href" |
There was a problem hiding this comment.
Reporting this as Href seems fair to me. When metal_gateways is included ?include=, this will be a MetalGatewayLite. I don't believe we have simple ways to express that today other than with the description.
displague
approved these changes
Aug 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #32
@displague @VamshikShetty