chore(ci): adopt METAL_AUTH_TOKEN to align with other tools #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctreatma
commented
Jul 30, 2024
| @@ -58,6 +58,6 @@ jobs: | |||
| - name: run tests | |||
| run: make testall | |||
| env: | |||
| METAL_API_TOKEN: ${{ secrets.METAL_API_TOKEN }} | |||
| METAL_AUTH_TOKEN: ${{ secrets.METAL_AUTH_TOKEN }} | |||
There was a problem hiding this comment.
Note that this change won't take effect until the PR is merged. I'll kick off a manual run of the other test workflow to validate the change.
There was a problem hiding this comment.
Orrrr not...the integration test workflow only has a push trigger on main, so we'll have to take this change on faith.
ctreatma
commented
Jul 30, 2024
| ifneq ("${METAL_API_TOKEN}", "") | ||
| @echo "metal_api_token: ${METAL_API_TOKEN}" > $(INTEGRATION_CONFIG); | ||
| ifneq ("${METAL_AUTH_TOKEN}", "") | ||
| @echo "metal_api_token: ${METAL_AUTH_TOKEN}" > $(INTEGRATION_CONFIG); |
There was a problem hiding this comment.
This change is CI-only, so the metal_api_token module parameter has not been renamed. Renaming that parameter--as well as deprecating and removing the METAL_API_TOKEN env var--is a bigger change with limited benefit at the moment.
|
Related to #87 |
|
This PR is included in version 0.10.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.