-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Testing Report #122
test: Testing Report #122
Conversation
thogarty
commented
Aug 20, 2024
•
edited
Loading
edited
- Created IBM test without external provider and updated UAT test to use it instead of the main example
- Updated UAT GHA testing workflow to output test report after test runs
- Update Prod GHA testing workflows to output test report after test runs
319e10b
to
aeece4b
Compare
@thogarty Please share the final testing report (screenshot or logs) generated with this code. |
@d-bhola, we decided not to do screenshots (not easily viewable) and just have the reviewer look at the latest action runs for the PR. You can view them here: |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We haven't added README.md and terraform.tfvars.example files to exmples-without-provider folder.
@srushti-patl , we aren't exposing those examples publicly. They're just for internal testing and don't require the additional context. We only need README.md's and .tfvars.example for published example modules |
Is there a way to remove/modify the question marks for better presentation of the test report? |
@d-bhola , beyond the scope of this task. We're using third party tools for the heavy lifting and that would require a second fork (we're already using a fork of go-junit-report). If we had more control over the source code I'd be happy to oblige but it's too much effort for too little reward. |
Ok.👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few comments. Rest all looks good.
Needs rebase |
…ression for faster viewing
d412a93
to
82f4178
Compare
@@ -0,0 +1,349 @@ | |||
# Fabric Port to Fabric IBM 2.0 Service Profile Connection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thogarty - As you mentioned in your previous comment, we don't need README.md here
@@ -0,0 +1,25 @@ | |||
equinix_client_id = "MyEquinixClientId" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this. We don't need terraform.tfvars.example