Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Testing Report #122

Merged
merged 13 commits into from
Aug 28, 2024
Merged

test: Testing Report #122

merged 13 commits into from
Aug 28, 2024

Conversation

thogarty
Copy link
Collaborator

@thogarty thogarty commented Aug 20, 2024

  • Created IBM test without external provider and updated UAT test to use it instead of the main example
  • Updated UAT GHA testing workflow to output test report after test runs
  • Update Prod GHA testing workflows to output test report after test runs

@d-bhola
Copy link
Collaborator

d-bhola commented Aug 27, 2024

@thogarty Please share the final testing report (screenshot or logs) generated with this code.

Copy link
Collaborator

@srushti-patl srushti-patl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't added README.md and terraform.tfvars.example files to exmples-without-provider folder.

@thogarty
Copy link
Collaborator Author

@srushti-patl , we aren't exposing those examples publicly. They're just for internal testing and don't require the additional context. We only need README.md's and .tfvars.example for published example modules

@d-bhola
Copy link
Collaborator

d-bhola commented Aug 27, 2024

Is there a way to remove/modify the question marks for better presentation of the test report?

@thogarty
Copy link
Collaborator Author

@d-bhola , beyond the scope of this task. We're using third party tools for the heavy lifting and that would require a second fork (we're already using a fork of go-junit-report). If we had more control over the source code I'd be happy to oblige but it's too much effort for too little reward.

@d-bhola
Copy link
Collaborator

d-bhola commented Aug 27, 2024

@d-bhola , beyond the scope of this task. We're using third party tools for the heavy lifting and that would require a second fork (we're already using a fork of go-junit-report). If we had more control over the source code I'd be happy to oblige but it's too much effort for too little reward.

Ok.👍

Copy link
Collaborator

@d-bhola d-bhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments. Rest all looks good.

@d-bhola
Copy link
Collaborator

d-bhola commented Aug 27, 2024

Needs rebase

@@ -0,0 +1,349 @@
# Fabric Port to Fabric IBM 2.0 Service Profile Connection
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thogarty - As you mentioned in your previous comment, we don't need README.md here

@@ -0,0 +1,25 @@
equinix_client_id = "MyEquinixClientId"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this. We don't need terraform.tfvars.example

@thogarty thogarty merged commit 1aae259 into main Aug 28, 2024
3 checks passed
@thogarty thogarty deleted the terratest-report branch August 28, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants