Apply Equinix TF Modules examples/ conventions (using existing samples) #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
…ashboard_via_IP*) Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
displague
changed the title
displague
commented
May 15, 2023
| @@ -245,72 +245,38 @@ root@controller:~# openstack server list | |||
|
|
|||
| ## External Networking Support | |||
|
|
|||
| External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see https://www.packet.com/developers/docs/network/basic/elastic-ips/ for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs. | |||
| External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see <https://metal.equinix.com/developers/docs/networking/elastic-ips/> for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs. | |||
There was a problem hiding this comment.
This URL could be updated to deploy. Redirects may handle it for now.
There was a problem hiding this comment.
Suggested change
| External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see <https://metal.equinix.com/developers/docs/networking/elastic-ips/> for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs. | |
| External (Provider) networking allows VMs to be assigned Internet addressable floating IPs. This allows the VMs to offer Internet accessible services (i.e. SSH and HTTP). This requires the a block of IP addresses from Equinix Metal (elastic IP address). These can be requested through the Equinix Metal Web GUI. Please see <https://deploy.equinix.com/developers/docs/metal/networking/elastic-ips/> for more details. Public IPv4 of at least /29 is recommended. A /30 will provide only a single floating IP. A /29 allocation will provide 5 floating IPs. |
displague
commented
May 15, 2023
| @@ -10,7 +10,8 @@ In each example, there is a module declaration such as: | |||
| variable "metal_auth_token" {} | |||
|
|
|||
| module "openstack" { | |||
| source = "metal/openstack/metal" | |||
| # source = "../.." | |||
| source = "equinix/openstack/metal" | |||
There was a problem hiding this comment.
This project should get moved to equinix-labs and be renamed to terraform-equinix-metal-openstack
|
If not in this PR, than in a successor, the |
displague
added
the
area/ci-cd-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply Equinix TF Modules
examples/conventions (using existing samples).For more on the conventions, see https://github.com/equinix-labs/equinix-labs/blob/main/terraform-modules.md; not all applied in this PR. More could be pulled in through adopting some of the CI and practices from https://github.com/equinix-labs/terraform-equinix-template/.
Removes managed storage options.
Continues #63
Fixes #60
Blocked by: