Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): delay release publish until after artifacts are attached #834

Merged
merged 1 commit into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 26 additions & 14 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,40 @@ on:

jobs:

goreleaser:
release:
name: Release
runs-on: ubuntu-latest

steps:
outputs:
new_release_published: ${{ steps.release.outputs.new_release_published }}
new_release_git_tag: ${{ steps.release.outputs.new_release_git_tag }}

- name: Check out code into the Go module directory
steps:
- name: Check out code
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Release
id: release
uses: cycjimmy/semantic-release-action@v4
with:
extra_plugins: |
[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

publish:
name: Publish
needs: release
if: needs.release.outputs.new_release_published == 'true'
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v4
with:
ref: "${{ needs.release.outputs.new_release_git_tag }}"

- name: Set up Go
uses: actions/setup-go@v5
with:
Expand All @@ -28,17 +51,6 @@ jobs:
gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
passphrase: ${{ secrets.PASSPHRASE }}

- name: Release
uses: cycjimmy/semantic-release-action@v3
with:
semantic_version: 19.0.5
extra_plugins: |
@semantic-release/[email protected]
@semantic-release/[email protected]
[email protected]
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Run GoReleaser
uses: goreleaser/goreleaser-action@v6
with:
Expand Down
31 changes: 1 addition & 30 deletions .goreleaser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,45 +32,15 @@ builds:
- goos: darwin
goarch: "386"
binary: "{{ .ProjectName }}_v{{ .Version }}"
- id: migration-tool
dir: ./cmd/migration-tool/
env:
# goreleaser does not work with CGO, it could also complicate
# usage by users in CI/CD systems like Terraform Cloud where
# they are unable to install libraries.
- CGO_ENABLED=0
mod_timestamp: "{{ .CommitTimestamp }}"
flags:
- -trimpath
ldflags:
- "-s -w -X main.Version={{.Version}}"
goos:
- freebsd
- windows
- linux
- darwin
goarch:
- amd64
- "386"
- arm
- arm64
ignore:
- goos: darwin
goarch: "386"
binary: equinix-migration-tool/equinix-migration-tool
archives:
- format: zip
name_template: "{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}"
builds:
- provider
- migration-tool
files:
- LICENSE*
- README*
- CHANGELOG*
- src: "cmd/migration-tool/*.md"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good time to chase with a PR to remove the tool and any other remnants (including doc mentions).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dst: equinix-migration-tool
strip_parent: true
checksum:
name_template: "{{ .ProjectName }}_{{ .Version }}_SHA256SUMS"
algorithm: sha256
Expand All @@ -88,5 +58,6 @@ signs:
- "${artifact}"
release:
mode: "keep-existing"
use_existing_draft: true
changelog:
disable: true
12 changes: 2 additions & 10 deletions .releaserc.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,8 @@
{
"successComment": "This ${issue.pull_request ? 'PR is included' : 'issue has been resolved'} in version ${nextRelease.version} :tada:",
"labels": false,
"releasedLabels": false
}
],
[
"@semantic-release/git",
{
"message": "ci: regenerate code for version ${nextRelease.version}",
"assets": [
"."
]
"releasedLabels": false,
"draftRelease": true
}
]
]
Expand Down
Loading