Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fsargs for helm scans, add debug, deprecate security checks and add scanners #105

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

fishnix
Copy link
Contributor

@fishnix fishnix commented Feb 17, 2024

This PR fixes a few minor issues:

  1. It looks like the plugin is doing a direct config scan if the helm overrides is passed, which means the scan will then fail when the fs scan runs. I don't think this is the desired behavior and the overrides flag should be passed to the fs scan.
  2. Adds a debug option that was incredibly useful during the development of the above
  3. Add support for "scanners" and deprecation notices for "security checks" per the trivy docs

@fishnix fishnix changed the title Use fsargs for helm scans instead of running a config check Use fsargs for helm scans, add debug, deprecate security checks and add scanners Feb 17, 2024
@fishnix fishnix marked this pull request as ready for review February 17, 2024 14:15
Copy link

@rkukura rkukura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gradientsearch gradientsearch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thx @fishnix

@fishnix fishnix merged commit c09118e into equinixmetal-buildkite:main Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants