Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix 100% width bug by removing contain strict #3258

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

magnh
Copy link
Contributor

@magnh magnh commented Feb 5, 2024

Setting width="100% does not currently work due to the current contain CSS value. Removing the contain attribute from the table wrapper element solves the issue. Setting contain: strict for performance reasons can be done per project by nesting classes using styled-components.

#3251

@yusijs

@magnh magnh requested review from vnys and oddvernes as code owners February 5, 2024 15:51
@magnh magnh force-pushed the fix/enable-100-width-on-data-grid branch from ec7b826 to a5e3c68 Compare February 5, 2024 15:52
@magnh magnh force-pushed the fix/enable-100-width-on-data-grid branch from a5e3c68 to e630ac4 Compare February 5, 2024 15:53
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oddvernes oddvernes merged commit b97e646 into equinor:develop Feb 6, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants