Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prop-spreading in datagrid + add defaultColumn prop #3300

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Fix prop-spreading in datagrid + add defaultColumn prop #3300

merged 2 commits into from
Feb 28, 2024

Conversation

yusijs
Copy link
Contributor

@yusijs yusijs commented Feb 28, 2024

oddvernes
oddvernes approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@oddvernes oddvernes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusijs yusijs merged commit 67f0360 into develop Feb 28, 2024
6 checks passed
@oddvernes oddvernes deleted the RHENRI/datagrid-tweaks-fixes branch February 28, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddvernes oddvernes oddvernes approved these changes

@vnys vnys Awaiting requested review from vnys vnys is a code owner

@torleifhalseth torleifhalseth Awaiting requested review from torleifhalseth torleifhalseth is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

key prop warning on TableHeaderCell__Cell
2 participants
@yusijs @oddvernes