-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new color tokens and variables in code #3733
Open
torleifhalseth
wants to merge
47
commits into
develop
Choose a base branch
from
feat/new-color-tokens
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d24ff14
to
51ac6b0
Compare
51ac6b0
to
df18ab5
Compare
…ations to run as esm
…ic color, matrix color and typography/spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
eds-tokens-build
package, focusing on improving the build process, adding new transforms, and updating configurations. The most significant changes are grouped by theme below.Build Process Improvements:
Use the new color library to sync tokens
Build Process Improvements:
build
script inpackage.json
to correct a typo and added new scripts for updating tokens and Figma colors.tsc
tovite
inpackages/eds-tokens-build/package.json
and addedvite
andvite-plugin-dts
as dependencies. [1] [2]Refactor Transforms:
includeTokenFilter
to filter tokens based on names and file path segments.createDensitySpaceToggleTransform
to handle density space toggling for design tokens.fontQuote
transform to wrap font values in quotes.createLightDarkTransform
to handle light and dark mode transformations for color tokens.pxFormatted
transform to format certain number tokens as pixel values.pxToRem
transform to convert pixel values to rem units.Configuration Updates:
tsconfig.json
to targetES2020
, include DOM libraries, and enable importing TS extensions.vite.config.ts
file to configure Vite for building the package, including rollup options and external dependencies.Utility Functions:
packages/eds-tokens-build/src/utils/index.ts
for transforming numbers to rem units, resolving references, and extending Style Dictionary configurations.