-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement output constraint scaling #10003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
1a7af5d
to
0bd54e9
Compare
CodSpeed Performance ReportMerging #10003 will not alter performanceComparing Summary
|
9a21fe0
to
84b593f
Compare
yngve-sk
reviewed
Feb 7, 2025
yngve-sk
reviewed
Feb 7, 2025
yngve-sk
reviewed
Feb 7, 2025
yngve-sk
reviewed
Feb 7, 2025
yngve-sk
reviewed
Feb 7, 2025
yngve-sk
reviewed
Feb 7, 2025
...ots/test_ropt_initialization/test_everest2ropt_snapshot/config_advanced.yml/ropt_config.json
Show resolved
Hide resolved
yngve-sk
reviewed
Feb 7, 2025
yngve-sk
reviewed
Feb 7, 2025
84b593f
to
2bf7a0f
Compare
yngve-sk
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think this clarifies the "sampling ensemble" being there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR reimplements output constraint scaling
Approach
See #9985, a similar approach for objective scaling, this PR builds on top of that.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests'
)When applicable