Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement output constraint scaling #10003

Merged
merged 3 commits into from
Feb 7, 2025
Merged

Conversation

verveerpj
Copy link
Contributor

Issue
This PR reimplements output constraint scaling

Approach
See #9985, a similar approach for objective scaling, this PR builds on top of that.

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@verveerpj verveerpj added release-notes:skip If there should be no mention of this in release notes everest labels Feb 6, 2025
@verveerpj verveerpj self-assigned this Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
437 2 435 24
View the top 2 failed tests by shortest run time
tests/everest/test_math_func.py::test_math_func_auto_scaled_constraints
Stack Traces | 0.018s run time
file .../tests/everest/test_math_func.py, line 189
  @pytest.mark.integration_test
  def test_math_func_auto_scaled_constraints(
E       fixture 'evaluator_server_config_generator' not found
>       available fixtures: _session_event_loop, anyio_backend, anyio_backend_name, anyio_backend_options, benchmark, benchmark_weave, cache, cached_example, capfd, capfdbinary, caplog, capsys, capsysbinary, change_to_tmpdir, class_mocker, control_config, control_data_no_variables, copy_egg_test_data_to_tmp, copy_math_func_test_data_to_tmp, copy_mocked_test_data_to_tmp, copy_template_test_data_to_tmp, copy_test_data_to_tmp, copy_testdata_tmpdir, cov, doctest_namespace, event_loop, event_loop_policy, filter_warnings, min_config, mock_server, mocker, module_mocker, monkeypatch, no_cover, package_mocker, pytestconfig, qapp, qapp_args, qapp_cls, qtbot, qtlog, qtmodeltester, record_property, record_testsuite_property, record_xml_attribute, recwarn, session_mocker, snapshot, testdata, testrun_uid, tests/everest/test_math_func.py::<event_loop>, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, unused_tcp_port, unused_tcp_port_factory, unused_udp_port, unused_udp_port_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

.../tests/everest/test_math_func.py:189
tests/everest/test_math_func.py::test_math_func_auto_scaled_objectives
Stack Traces | 0.018s run time
file .../tests/everest/test_math_func.py, line 161
  @pytest.mark.integration_test
  def test_math_func_auto_scaled_objectives(
E       fixture 'evaluator_server_config_generator' not found
>       available fixtures: _session_event_loop, anyio_backend, anyio_backend_name, anyio_backend_options, benchmark, benchmark_weave, cache, cached_example, capfd, capfdbinary, caplog, capsys, capsysbinary, change_to_tmpdir, class_mocker, control_config, control_data_no_variables, copy_egg_test_data_to_tmp, copy_math_func_test_data_to_tmp, copy_mocked_test_data_to_tmp, copy_template_test_data_to_tmp, copy_test_data_to_tmp, copy_testdata_tmpdir, cov, doctest_namespace, event_loop, event_loop_policy, filter_warnings, min_config, mock_server, mocker, module_mocker, monkeypatch, no_cover, package_mocker, pytestconfig, qapp, qapp_args, qapp_cls, qtbot, qtlog, qtmodeltester, record_property, record_testsuite_property, record_xml_attribute, recwarn, session_mocker, snapshot, testdata, testrun_uid, tests/everest/test_math_func.py::<event_loop>, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory, unused_tcp_port, unused_tcp_port_factory, unused_udp_port, unused_udp_port_factory, worker_id
>       use 'pytest --fixtures [testpath]' for help on them.

.../tests/everest/test_math_func.py:161

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@verveerpj verveerpj force-pushed the reimplement-constraint-scaling branch from 1a7af5d to 0bd54e9 Compare February 6, 2025 14:26
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #10003 will not alter performance

Comparing reimplement-constraint-scaling (2bf7a0f) with main (856cc02)

Summary

✅ 25 untouched benchmarks

@verveerpj verveerpj force-pushed the reimplement-constraint-scaling branch 4 times, most recently from 9a21fe0 to 84b593f Compare February 7, 2025 12:11
@verveerpj verveerpj force-pushed the reimplement-constraint-scaling branch from 84b593f to 2bf7a0f Compare February 7, 2025 13:08
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this clarifies the "sampling ensemble" being there

@verveerpj verveerpj enabled auto-merge (rebase) February 7, 2025 13:20
@verveerpj verveerpj merged commit 6e7525d into main Feb 7, 2025
26 checks passed
@verveerpj verveerpj deleted the reimplement-constraint-scaling branch February 7, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
everest release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants