Make everserver port selection random #10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10010 will not alter performanceComparing Summary
|
DanSava
reviewed
Feb 7, 2025
| @@ -273,7 +274,8 @@ def get_shared_data( | |||
|
|
|||
|
|
|||
| def _find_open_port(host, lower, upper) -> int: | |||
| for port in range(lower, upper): | |||
| for _ in range(5): | |||
There was a problem hiding this comment.
Just 5 tries seems a low number.
There was a problem hiding this comment.
It tries 5 times to randomly find a port not in use in the range 5000 to 5800. Should be low probability of not finding one
DanSava
reviewed
Feb 7, 2025
| @@ -273,7 +274,8 @@ def get_shared_data( | |||
|
|
|||
|
|
|||
| def _find_open_port(host, lower, upper) -> int: | |||
| for port in range(lower, upper): | |||
| for _ in range(5): | |||
| port = random.randint(lower, upper) | |||
There was a problem hiding this comment.
Maybe add a comment just to have an idea why this was needed so that once we update further everserver we might undo it.
DanSava
approved these changes
Feb 7, 2025
|
I will up the retry to 10 and add a comment |
frode-aarstad
force-pushed
the
everserver-port-selection
branch
from
46d8668 to
8d9ceba
Compare
frode-aarstad
force-pushed
the
everserver-port-selection
branch
from
8d9ceba to
a459d69
Compare
frode-aarstad
added
the
release-notes:maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9934
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable