Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potentially flaky test for fm_runner #10029

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

jonathan-eq
Copy link
Contributor

@jonathan-eq jonathan-eq commented Feb 11, 2025

Approach
This commit fixes a potentially flaky test for fm_runner

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@jonathan-eq jonathan-eq self-assigned this Feb 11, 2025
@jonathan-eq jonathan-eq added the release-notes:flaky-test-fix PR fixes a flaky test label Feb 11, 2025
Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #10029 will not alter performance

Comparing jonathan-eq:fix-flaky-tests8 (facbe44) with main (dd9be56)

Summary

✅ 25 untouched benchmarks

@jonathan-eq jonathan-eq merged commit a43fa17 into equinor:main Feb 11, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:flaky-test-fix PR fixes a flaky test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants