Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport logging and timeout fix #10046

Merged

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Feb 12, 2025

Backport of #9086 , #10028 and #10036

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj force-pushed the backport_logging_and_timeout_fix branch from 9918a9f to b8c175f Compare February 12, 2025 13:10
@larsevj larsevj force-pushed the backport_logging_and_timeout_fix branch from b8c175f to 9e51947 Compare February 12, 2025 13:13
@larsevj larsevj requested a review from eivindjahren February 12, 2025 13:15
Copy link

codspeed-hq bot commented Feb 12, 2025

CodSpeed Performance Report

Merging #10046 will not alter performance

Comparing larsevj:backport_logging_and_timeout_fix (9e51947) with main (cc15585)

Summary

✅ 24 untouched benchmarks
⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ test_plotter_on_all_snake_oil_responses_time[0] 11 s N/A N/A

@larsevj larsevj merged commit a3ba654 into equinor:version-13.0 Feb 12, 2025
26 of 27 checks passed
@larsevj larsevj deleted the backport_logging_and_timeout_fix branch February 12, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants