Update communication between the everest server job and the experiment server #10051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #10051 will not alter performanceComparing Summary
|
DanSava
force-pushed
the
fix_bleeding
branch
from
9f5e64b to
ef357c2
Compare
Communicate with the server thread via a simple queue
DanSava
force-pushed
the
fix_bleeding
branch
from
ef357c2 to
ad404c7
Compare
| @@ -136,94 +123,8 @@ def test_configure_logger_failure(_, tmp_path, change_to_tmpdir): | |||
|
|
|||
| @patch("sys.argv", ["name", "--output-dir", "everest_output"]) | |||
| @patch("everest.detached.jobs.everserver._configure_loggers") | |||
| @patch("requests.get") | |||
| def test_status_running_complete(mocked_get, _, change_to_tmpdir): | |||
| def mocked_server(url, verify, auth, timeout, proxies): | |||
There was a problem hiding this comment.
Is this test not relevant anymore?
There was a problem hiding this comment.
I might have been a bit ✂️ happy with this one I will put it back and update it.
DanSava
added
release-notes:bug-fix
DanSava
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #10019
Approach
Remove communication between the Everest server job and the Everest experiment server via HTTP calls and replace it with a message queue.
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable