-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make forwardmodelrunner async #9198
Open
jonathan-eq
wants to merge
23
commits into
equinor:main
Choose a base branch
from
jonathan-eq:main4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
df42399
Refactor forwardmodelrunner to be async
jonathan-eq e299ba6
fix tests
jonathan-eq f609f5e
fix more tests
jonathan-eq 84e389a
fix even more tests
jonathan-eq 2b8c74a
Fix failed realization not being marked as failed
jonathan-eq d2af117
Add `ForwardModelRunnerException`class
jonathan-eq b4fb94a
Add more asyncio.sleep()
jonathan-eq e1c15df
Change pattern from generator to asyncio.Queue
jonathan-eq 129642d
Fix tests and remove statemachine
jonathan-eq 5d3cac8
Fix asyncio.TimeoutError in event.py
jonathan-eq fbd1c48
cleanup
jonathan-eq 53f999a
Fix no-such-process error
jonathan-eq aa5f66e
further cleanup
jonathan-eq a2a0b86
Fix process_tree test
jonathan-eq d01b408
Fix tests
jonathan-eq 22e625a
Have termination not raise asyncio.CancellationError for every real
jonathan-eq c013b93
code review suggestions
jonathan-eq b797a75
more cleanup
jonathan-eq 6b66226
Undo changes `asyncio.Event->bool`
jonathan-eq 408f9d9
Remove import quotations of AsyncGenerator
jonathan-eq 157d424
Remove rogue prints
jonathan-eq 443584c
Bump test_custom_weights_stored_and_retrieved_from_metadata_esmda tim…
jonathan-eq 1c46165
Bump test_field_param_update_using_heat_equation timeout -> 600s
jonathan-eq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix tests
- Loading branch information
commit e299ba62a4850ddb5c510335242b6d2ffb991f7c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we need this helper function at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need it for one of the tests.
test_job_dispatch.py::test_retry_of_jobs_json_file_read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this usage of that function is a bit strange though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We mock it to
lock.acquire
in a test, so that it will stop here