Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave test machine usable when running rapid-tests #9235

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

berland
Copy link
Contributor

@berland berland commented Nov 15, 2024

Running with a lower CPU priority helps this

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Running with a lower CPU priority helps this
@berland berland self-assigned this Nov 15, 2024
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Nov 15, 2024
@berland berland enabled auto-merge (rebase) November 15, 2024 14:17
Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@berland berland merged commit c46b061 into equinor:main Nov 16, 2024
42 checks passed
@berland berland deleted the nice_just branch December 27, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:skip If there should be no mention of this in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants