Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where site config was not propagated to Everest config #9719

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Jan 13, 2025

Issue
Resolves #9783

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

Copy link

codspeed-hq bot commented Jan 13, 2025

CodSpeed Performance Report

Merging #9719 will not alter performance

Comparing oyvindeide:change_site_config (13760e0) with main (336c4a2)

Summary

✅ 25 untouched benchmarks

@oyvindeide oyvindeide force-pushed the change_site_config branch 8 times, most recently from da1f1db to 1d74782 Compare January 16, 2025 08:27
@oyvindeide oyvindeide self-assigned this Jan 16, 2025
@oyvindeide oyvindeide added the release-notes:bug-fix Automatically categorise as bug fix in release notes label Jan 16, 2025
@oyvindeide oyvindeide force-pushed the change_site_config branch 2 times, most recently from 116ec8f to f9b110d Compare January 17, 2025 08:31
@oyvindeide oyvindeide changed the title Add function to propagate context to validation Fix bug where site config was not propagated to Everest config Jan 17, 2025
@oyvindeide oyvindeide force-pushed the change_site_config branch 6 times, most recently from e8f8737 to 1017e5d Compare January 17, 2025 13:27
# Use from plugin system if user has not specified
plugin_script = None
if info.context:
plugin_script = info.context.get(info.field_name)
Copy link
Contributor

@yngve-sk yngve-sk Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that runs this line? EDIT: I see running test_detached triggers it, but do any of the ERT tests run it? Is this mainly meant for things we run via Everest?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for everest only at the moment, though we could do the same for ert. There will be no context when using ert.

Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, requires a rebase.

src/ert/config/queue_config.py Show resolved Hide resolved
src/everest/config/everest_config.py Outdated Show resolved Hide resolved
src/everest/config/everest_config.py Show resolved Hide resolved
src/everest/config/everest_config.py Outdated Show resolved Hide resolved
src/everest/config/everest_config.py Show resolved Hide resolved
tests/everest/test_detached.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:bug-fix Automatically categorise as bug fix in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different queue requirements for ert and everest
3 participants