-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug where site config was not propagated to Everest config #9719
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging #9719 will not alter performanceComparing Summary
|
da1f1db
to
1d74782
Compare
116ec8f
to
f9b110d
Compare
e8f8737
to
1017e5d
Compare
src/ert/config/queue_config.py
Outdated
# Use from plugin system if user has not specified | ||
plugin_script = None | ||
if info.context: | ||
plugin_script = info.context.get(info.field_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test that runs this line? EDIT: I see running test_detached
triggers it, but do any of the ERT tests run it? Is this mainly meant for things we run via Everest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for everest only at the moment, though we could do the same for ert. There will be no context when using ert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, requires a rebase.
1017e5d
to
fae468e
Compare
fae468e
to
13760e0
Compare
Issue
Resolves #9783
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable