-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ErtConfig from EverestRunModel #9869
Open
frode-aarstad
wants to merge
2
commits into
equinor:main
Choose a base branch
from
frode-aarstad:remove-ert-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frode-aarstad
force-pushed
the
remove-ert-config
branch
from
January 24, 2025 12:31
f169178
to
448fe6b
Compare
CodSpeed Performance ReportMerging #9869 will improve performances by 10.33%Comparing Summary
Benchmarks breakdown
|
frode-aarstad
force-pushed
the
remove-ert-config
branch
from
January 24, 2025 12:48
448fe6b
to
851bcae
Compare
frode-aarstad
force-pushed
the
remove-ert-config
branch
3 times, most recently
from
January 24, 2025 12:58
15834f2
to
986b1c5
Compare
frode-aarstad
added
the
release-notes:refactor
PR changes code without changing ANY (!) behavior.
label
Jan 24, 2025
frode-aarstad
force-pushed
the
remove-ert-config
branch
from
January 24, 2025 13:16
986b1c5
to
10c4070
Compare
yngve-sk
reviewed
Jan 27, 2025
result[variable.name].append(str(variable.index)) | ||
return dict(result) | ||
|
||
# This adds an EXT_PARAM key to the ert_config, which is not a true ERT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code corresponding to this in everest_to_ert.py
can be removed now that this is done here, as well as the test test_everest_to_ert_controls
frode-aarstad
force-pushed
the
remove-ert-config
branch
from
January 29, 2025 09:00
2db4cb5
to
347507a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9789
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"'
)When applicable