Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cpuseconds #9879

Open
wants to merge 5 commits into
base: version-12.1
Choose a base branch
from

Conversation

andreas-el
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests tests/everest -n auto --hypothesis-profile=fast -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

berland and others added 5 commits January 24, 2025 14:50
The summation of cpu_seconds for a process and all its descendants can
never work properly during teardown of a process tree, as the root
process typically outlives its children. Thus, the maximum observed
cpu_seconds for a process tree is always the best estimate of the
correct sum.
Remove `macos-13` since this is excluded for specified python version
Change `macos-14` to `macos-latest` as we want to build for arm-architecture,
and also this aligns with our free CI-minutes
Remove `macos-14-large` as testing also on `x64` architecture seems excessive.
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #9879 will degrade performances by 82.77%

Comparing andreas-el:backport_cpuseconds (7f61550) with main (ff2f481)

Summary

⚡ 5 improvements
❌ 1 regressions
✅ 18 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_and_benchmark_adaptive_localization_with_fields 3 s 17.2 s -82.77%
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_parameters] 253.6 µs 144.6 µs +75.38%
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-gen_data_with_obs-get_parameters] 252.7 µs 143.7 µs +75.8%
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary-get_parameters] 258.4 µs 148.6 µs +73.86%
test_direct_dark_performance[gen_x: 20, sum_x: 20 reals: 10-summary_with_obs-get_parameters] 252.8 µs 143.9 µs +75.76%
test_direct_dark_performance_with_storage[gen_x: 20, sum_x: 20 reals: 10-gen_data-get_record_observations] 1.5 ms 1.4 ms +13.19%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants