Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select-string #9895

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fix select-string #9895

merged 2 commits into from
Jan 29, 2025

Conversation

eivindjahren
Copy link
Contributor

@eivindjahren eivindjahren commented Jan 29, 2025

Run where this worked correctly on mac: https://github.com/equinor/ert/actions/runs/13025635665/job/36334142343?pr=9895

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@eivindjahren eivindjahren added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 29, 2025
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #9895 will not alter performance

Comparing eivindjahren:fix_select_string (181769a) with main (6a0336a)

Summary

✅ 25 untouched benchmarks

@eivindjahren eivindjahren self-assigned this Jan 29, 2025
@eivindjahren eivindjahren enabled auto-merge (rebase) January 29, 2025 06:29
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Lets make rapid tests rapid again 🥇

@eivindjahren eivindjahren merged commit 8971fd9 into equinor:main Jan 29, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants