Add more validation to design matrix #9915
Conversation
jonathan-eq
force-pushed
the
validate-design-matrix
branch
from
ef743e9 to
09a6a89
Compare
jonathan-eq
added
the
release-notes:improvement
jonathan-eq
force-pushed
the
validate-design-matrix
branch
from
09a6a89 to
dc7757f
Compare
CodSpeed Performance ReportMerging #9915 will improve performances by 12.16%Comparing Summary
Benchmarks breakdown
|
| @@ -88,6 +88,9 @@ def __init__( | |||
| self._active_realizations_field.setText( | |||
| ActiveRange(design_matrix.active_realizations).rangestring | |||
| ) | |||
| self._active_realizations_field.setValidator( | |||
| RangeStringArgument(design_matrix.get_num_realizations()) | |||
There was a problem hiding this comment.
This would not work if the user is missing realizations in their designmatrix. Example: User only has real 0,1,5,6,9 in design matrix. This range string would not be validated correctly in this case.
There was a problem hiding this comment.
Then if we don't have such a custom validator, I'd say let's just check on the actual run whether the active realization mask matches the active realizations in the field box?
There was a problem hiding this comment.
If we can validate it on the actual run; then it should be a small task to have it validated before enabling the run button.
Initial count:
Validator that counts incorrectly:
There was a problem hiding this comment.
Yes, but active_mask=[0,5,9] and you set it to 0-9?
jonathan-eq
force-pushed
the
validate-design-matrix
branch
3 times, most recently
from
b60441e to
e003f77
Compare
There was a problem hiding this comment.
Very nice PR @jonathan-eq ! Could you update the commit message that includes all the new items that it adds?
jonathan-eq
force-pushed
the
validate-design-matrix
branch
2 times, most recently
from
8a97a57 to
cdffdb1
Compare
This commit adds some validation to design matrix, and also makes the active_realizations_field in the gui only accept realizations actually found in design matrix. The designmatrix validation added in this commit: * parameter names cannot contain multiple words * parameter names cannot be numerical
jonathan-eq
force-pushed
the
validate-design-matrix
branch
from
cdffdb1 to
6f3fb02
Compare
Issue
Resolves #8686
Approach
The commits in this PR add more validation to design matrix
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable