Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more ruff rules ICN, PIE #9931

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Add more ruff rules ICN, PIE #9931

merged 3 commits into from
Feb 3, 2025

Conversation

larsevj
Copy link
Contributor

@larsevj larsevj commented Jan 31, 2025

See https://docs.astral.sh/ruff/rules/#flake8-import-conventions-icn and https://docs.astral.sh/ruff/rules/#flake8-pie-pie

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@larsevj larsevj added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Jan 31, 2025
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #9931 will not alter performance

Comparing larsevj:add_ruff_rules (d1425fe) with main (3abaf02)

Summary

✅ 25 untouched benchmarks

@jonathan-eq jonathan-eq self-requested a review February 3, 2025 08:05
Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@larsevj larsevj merged commit 7c27a9c into equinor:main Feb 3, 2025
26 checks passed
@larsevj larsevj deleted the add_ruff_rules branch February 3, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes:maintenance Automatically categorise as maintenance change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants