New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let zmq select port in EnsembleEvaluator #9991

Merged

JHolba merged 1 commit into equinor:main from JHolba:zmq-selects-port

Feb 6, 2025

Contributor

JHolba commented Feb 6, 2025 •

edited

Loading

Issue
Resolves #9906
Resolves #9987

Approach
use zmq's bind_to_random_port instead of finding a port first and then trying to rebind it later.

PR title captures the intent of the changes, and is fitting for release notes.
Added appropriate release note label
Commit history is consistent and clean, in line with the contribution guidelines.
Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

When there are user facing changes: Updated documentation
New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
Large PR: Prepare changes in small commits for more convenient review
Bug fix: Add regression test for the bug
Bug fix: Create Backport PR to latest release

xjules reviewed

View reviewed changes

src/ert/ensemble_evaluator/evaluator.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

src/ert/ensemble_evaluator/evaluator.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

src/ert/ensemble_evaluator/config.py Show resolved Hide resolved

xjules reviewed

View reviewed changes

tests/ert/unit_tests/ensemble_evaluator/test_ensemble_evaluator.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

tests/ert/unit_tests/ensemble_evaluator/test_ensemble_evaluator.py Show resolved Hide resolved

xjules reviewed

View reviewed changes

tests/ert/unit_tests/ensemble_evaluator/conftest.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

src/ert/ensemble_evaluator/monitor.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

tests/ert/unit_tests/ensemble_evaluator/test_monitor.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

tests/ert/unit_tests/test_tracking.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

tests/ert/unit_tests/test_tracking.py Outdated Show resolved Hide resolved

codspeed-hq bot commented Feb 6, 2025 •

edited

Loading

CodSpeed Performance Report

Merging #9991 will not alter performance

_{Comparing JHolba:zmq-selects-port (6b40904) with main (912dbc8)}

Summary

✅ 25 untouched benchmarks

xjules reviewed

View reviewed changes

tests/ert/unit_tests/ensemble_evaluator/test_ensemble_evaluator.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

tests/ert/unit_tests/ensemble_evaluator/test_ensemble_legacy.py Outdated Show resolved Hide resolved

JHolba force-pushed the zmq-selects-port branch from a1bc1be to 47aa747 Compare

February 6, 2025 13:28

xjules reviewed

View reviewed changes

src/ert/gui/simulation/run_dialog.py Outdated Show resolved Hide resolved

xjules reviewed

View reviewed changes

src/ert/shared/net_utils.py Show resolved Hide resolved

JHolba force-pushed the zmq-selects-port branch from 47aa747 to 621e50a Compare

February 6, 2025 13:39

xjules reviewed

View reviewed changes

tests/everest/test_simulator_cache.py Outdated Show resolved Hide resolved


          Let zmq select ports itself

6b40904

zmq will select a port each time ensemble evaluator starts. This way
there will be no time where other programs can pick up the target
port before zmq does.
Removed large parts of net_utils and its tests that were no longer
needed.

JHolba force-pushed the zmq-selects-port branch from f26eb6b to 6b40904 Compare

February 6, 2025 13:54

JHolba marked this pull request as ready for review

February 6, 2025 13:56

JHolba changed the title ~~let zmq select port~~ Let zmq select port in EnsembleEvaluator

JHolba self-assigned this

JHolba added the release-notes:bug-fix label

xjules approved these changes

View reviewed changes

Contributor

xjules left a comment

Great! Nicely done @JHolba ! 🚀

JHolba mentioned this pull request

Let zmq select ports itself #10002

Merged

9 tasks

JHolba merged commit 7642464 into equinor:main

27 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:bug-fix