Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove evaluator_server_config_generator fixture #9997

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

xjules
Copy link
Contributor

@xjules xjules commented Feb 6, 2025

Issue
evaluator_server_config_generator is no longer required as LOCAL runs exploit ipc protocol (no ports are involved).

Approach
✂️

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@xjules xjules self-assigned this Feb 6, 2025
Copy link
Contributor

@yngve-sk yngve-sk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #9997 will not alter performance

Comparing xjules:fix_eeconfig_everest (2338692) with main (15f6077)

Summary

✅ 25 untouched benchmarks

@xjules xjules merged commit fb8fd2a into equinor:main Feb 6, 2025
27 checks passed
@xjules xjules deleted the fix_eeconfig_everest branch February 6, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants