Added new endpoints for Analytics #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larfeq
force-pushed
the
feat/analytics/update-endpoints-to-IAsyncEnumerable
branch
from
6090394 to
01996c8
Compare
src/backend/api/Fusion.Resources.Api/Controllers/Requests/AnalyticsController.cs
Outdated
Show resolved
Hide resolved
src/backend/api/Fusion.Resources.Api/Controllers/Requests/AnalyticsController.cs
Outdated
Show resolved
Hide resolved
...ackend/api/Fusion.Resources.Domain/Queries/GetResourceAllocationRequestsForAnalyticsAsync.cs
Outdated
Show resolved
Hide resolved
Jonathanio123
approved these changes
Feb 20, 2025
...ckend/api/Fusion.Resources.Domain/Queries/GetResourceAllocationRequestsForAnalyticsStream.cs
Outdated
Show resolved
Hide resolved
...ckend/api/Fusion.Resources.Domain/Queries/GetResourceAllocationRequestsForAnalyticsStream.cs
Outdated
Show resolved
Hide resolved
src/backend/api/Fusion.Resources.Domain/Queries/GetPersonsAbsenceForAnalyticsStream.cs
Outdated
Show resolved
Hide resolved
src/backend/api/Fusion.Resources.Domain/Queries/GetPersonsAbsenceForAnalyticsStream.cs
Outdated
Show resolved
Hide resolved
src/backend/api/Fusion.Resources.Api/Controllers/Requests/AnalyticsController.cs
Show resolved
Hide resolved
src/backend/api/Fusion.Resources.Api/Controllers/Requests/AnalyticsController.cs
Show resolved
Hide resolved
src/backend/api/Fusion.Resources.Domain/Models/PagedAsyncResult.cs
Outdated
Show resolved
Hide resolved
larfeq
deleted the
feat/analytics/update-endpoints-to-IAsyncEnumerable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
Thru the old endpoints PowerBI were able to pull alot of data and this forced us to upgrade the technical requirements of the server. To mitigate this problem new version of the same endpoints has been created using IAsyncEnumerable to return the data.
Further improvements might be needed.
AB#60374
Some test results for /analytics/requests/internal v1 vs v2:
In CI, both return 2098 enteties and 3.1 MB of data. V2 is 100-200 ms slower. Using Visual Studio diagnostics tools the object difference is 170 000 for v1 and 1686 for v2. The heap difference for v1 is 16 000 KB and for v2 is -45 KB. This measurement is tkane with a snapshot before and after execution of endpoint.
Testing:
Checklist: