Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send data-related warnings from backend in HTTP header and view frontend in respective modules #836

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

rubenthoms
Copy link
Collaborator

@rubenthoms rubenthoms commented Jan 6, 2025

This PR is aiming to implement #822.


Remaining challenges/questions

  • Tanstack Query is caching the responses of the API requests and is, hence, not calling the API function every time - how to cache/invalidate the warnings from backend such that only warnings for the actually visualized data are shown?
    • Add a default select to TanstackQuery and rather send the warnings as data and let users handle them in module? -> more complex module code and refactoring required; problematic when module authors want to make use of their own select functions as they have to implement the logic themselves.
    • Add a custom wrapper around useQuery?

@rubenthoms rubenthoms self-assigned this Jan 6, 2025
@rubenthoms rubenthoms marked this pull request as draft January 6, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant